Skip to content

add: unified_reward and qwen_image_bench#1471

Closed
yjy415 wants to merge 3 commits into
modelscope:mainfrom
yjy415:metric2
Closed

add: unified_reward and qwen_image_bench#1471
yjy415 wants to merge 3 commits into
modelscope:mainfrom
yjy415:metric2

Conversation

@yjy415
Copy link
Copy Markdown
Collaborator

@yjy415 yjy415 commented May 31, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for three new image quality metrics: Qwen-Image-Bench, UnifiedReward 2.0, and UnifiedReward Edit, including their respective models, metrics, state dict converters, documentation, and example scripts. The code review identified several critical issues: an accidental deletion of hidream_o1_image_series from the model configurations, a potential ValueError crash when parsing pairwise rank winners in UnifiedRewardEditModel, a potential AttributeError in fix_score_json if the input is not a dictionary, a greedy regex pattern that could break JSON extraction, and a redundant regex character class [::]. Additionally, the input normalization logic in UnifiedRewardEditModel can be simplified.

Comment thread diffsynth/configs/model_configs.py Outdated
Comment thread diffsynth/models/unified_reward_edit.py
Comment thread diffsynth/models/unified_reward_edit.py Outdated
Comment thread diffsynth/models/qwen_image_bench.py
Comment thread diffsynth/models/unified_reward_edit.py
Comment thread diffsynth/models/unified_reward_2.py
@Artiprocher Artiprocher closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants