Use build.get_image_tags for deployments from builds#1326
Open
4ndv wants to merge 1 commit intomoghtech:mainfrom
Open
Use build.get_image_tags for deployments from builds#13264ndv wants to merge 1 commit intomoghtech:mainfrom
build.get_image_tags for deployments from builds#13264ndv wants to merge 1 commit intomoghtech:mainfrom
Conversation
Member
|
Thanks for catching and fixing, will review shortly |
mbecker20
reviewed
Apr 24, 2026
| DeploymentImage::Build { build_id, version } => { | ||
| DeploymentImage::Build { | ||
| build_id, | ||
| version: _, |
Member
There was a problem hiding this comment.
version should not be unused here, please review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.get_image_tags()for building image tag for deploymentsget_image_tagsfor preserving current deployment behavior (to prefer full version tags). It's currently only used for running builds, and builder doesn't really care about the order:latestfor both builds and deployments if no other tags were added to not fail when all of the tagging options are disabledTried my best to test all the combinations, but I'm not very familiar with the codebase and may miss some things
Fixes #1325