feat: add query param webhook auth and fix empty body parsing#1389
Open
scolastico wants to merge 2 commits intomoghtech:mainfrom
Open
feat: add query param webhook auth and fix empty body parsing#1389scolastico wants to merge 2 commits intomoghtech:mainfrom
scolastico wants to merge 2 commits intomoghtech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Querywebhook authentication style and resolves an issue with empty webhook payloads.Changes:
QueryAuth) that allows external services to authenticate using a?secret=...query parameter instead of HTTP headers. It also optionally supports extracting the target branch via a?branch=...parameter (defaults tomain).VerifySecretandExtractBranchtraits across the router to receive the parsed query map, passing it down to all webhook handlers.Actionwebhooks would fail with anEOF while parsing a valueerror if triggered with an empty request body. It now safely defaults to aNullJSON value when the body is empty.Queryauth style to the UI dropdown options. When selected, the UI now displays helpful usage text underneath the Webhook URL field explaining the required secret and optional branch parameters.