[feat] support multiple image registries in stacks#1394
Open
marchrius wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to explicitly point out that I used Codex 5.5 for this task.
Summary
Ref. #496
Adds support for configuring multiple Docker image registries on Stack resources.
Previously, Stacks supported a single
registry_provider/registry_accountpair for logging in beforedocker compose/docker stackoperations. This change introducesimage_registryonStackConfig, allowing multiple registry/account pairs to be selected and used during stack pull, deploy, and run flows.Changes
image_registry: Vec<ImageRegistryConfig>toStackConfig.registry_provider/registry_accountfields.registry_tokentoregistry_tokens.Compatibility
Existing Stacks using
registry_provider/registry_accountcontinue to work.In the UI, legacy single-registry config is shown as a single registry row. When the Stack config is saved through the new UI, the value is written to
image_registryand the legacy fields are cleared.Validation
Tested locally with:
Screenshots:
Configurations
Download success
Download failed