Add foreign key constraints, fix tests - #45
Open
tbarmann wants to merge 4 commits into
Open
Conversation
tbarmann
requested review from
cathyzoller,
cbarber,
chewnoill and
priscilatrevino
as code owners
November 29, 2022 21:58
tbarmann
force-pushed
the
tb/add-references
branch
from
November 29, 2022 21:59
b59a651 to
8b4b5be
Compare
We will not need to update a join table
…ed by this change
tbarmann
force-pushed
the
tb/add-references
branch
from
November 30, 2022 16:00
8b4b5be to
36d2823
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds foreign key constraints to several tables: orders, order_items, order_item_options, and menus. This will ensure that changes/deletion to parent records will properly change/delete children records.
This also fixes a number of tests, which were automatically generated, so they use fixtures that generate real records instead of using hard-coded random ids for records.
Another change adds the
fakerlibrary to the project because some of the tests generate multiple users and users must have unique email addresses.