Open
Conversation
- Add phpstan/phpstan, szepeviktor/phpstan-wordpress and WooCommerce Subscriptions stubs - Configure PHPStan level 5 for core plugin files - Update WooCommerce stubs to ^10.6 - Add phpstan script to composer.json
# Conflicts: # composer.lock # yarn.lock
… outdated error ignores
…roduce-phpstan-at-level-5 # Conflicts: # composer.lock
…at-level-5 [PIWOO-714] Fix PHPStan warnings at level 5
- Resolved conflict in services.php: took upstream refactor of PayPalExpressButton factory (uses actual WC gateway instance, throws on missing gateway) - Fixed PHPStan: remove unreachable return after wp_send_json_error() in PayPalAjaxRequests - Fixed PHPStan: assert WC_Product_Variable before calling get_available_variations() in PayPalExpressButton::isVirtualProduct()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Currently, there are many psalm exclusion rules, making the results of static PHP analysis questionable.
PHP Static Analysis
As of 2025, PHP static analysis is done using PHPStan. For legacy projects, strive for compliance with level 5, if possible 7. More modern projects should pass level 8.
Current status:
Level 5 migration is finished and passing tests