Skip to content

Fix assets compiler error and remove gulp #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmaymo wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix assets compiler error and remove gulp #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 0 additions & 352 deletions gulpfile.js
View file
Open in desktop

This file was deleted.

14 changes: 2 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
}
],
"homepage": "https://github.com/mollie/WooCommerce",
"main": "gulpfile.js",
"repository": {
"type": "git",
"url": "git@github.com:mollie/WooCommerce.git"
Expand All @@ -32,27 +31,18 @@
"@babel/preset-env": "^7.4.5",
"@babel/preset-react": "^7.14.5",
"@playwright/test": "^1.33.0",
"@symfony/webpack-encore": "^4.5.0",
"@symfony/webpack-encore": "^3.0.0",
"@woocommerce/dependency-extraction-webpack-plugin": "^1.7.0",
"@wordpress/data": "^6.1.5",
"@wordpress/element": "^4.0.4",
"date-and-time": "^0.14.0",
"del": "^3.0.0",
"dotenv": "^16.0.0",
"gulp": "^4.0.2",
"gulp-cli": "^2.0.1",
"gulp-help-doc": "^1.1.1",
"gulp-rename": "^2.0",
"gulp-zip": "^4.2.0",
"minimist": "^1.2.3",
"pump": "^3.0.0",
"sass": "^1.52.1",
"sass-loader": "^7.0.1",
"wp-pot": "^1.10.2"
},
"scripts": {
"watch": "webpack --watch",
Copy link
Copy Markdown
Contributor

@inpsyde-maticluznar inpsyde-maticluznar Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmaymo Since you are doing this, you can change the watch script to

node_modules/.bin/encore dev --watch --env basePath=.

"build": "node_modules/.bin/encore dev --env.basePath=.",
"build": "node_modules/.bin/encore dev --env basePath=.",
"setup": "gulp setup",
"e2e-activation": "npx playwright test --project=activation",
"e2e-simple": "npx playwright test --project=simple-classic",
Expand Down
Loading