-
Notifications
You must be signed in to change notification settings - Fork 71
chore(deps): bump docker/setup-qemu-action from 3 to 4 #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/github_actions/docker/setup-qemu-action-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue in your code:
docker/setup-qemu-action@v4uses a movable tag, so a repointedv4tag could run attacker-controlled code in theSet up QEMUstep and tamper with build artifacts.More details about this
docker/setup-qemu-action@v4is pulled by the movablev4tag, so this workflow will run whatever code the action publisher points that tag to at build time. In this job, that action runs in theSet up QEMUstep beforedocker buildx build, so ifv4were repointed to a malicious commit, the attacker’s code would execute onubuntu-latestwith access to the checked-out repository and the job’s runtime credentials.A plausible attack looks like this:
docker/setup-qemu-actionrepository or a maintainer account and moves thev4tag to a new malicious commit.container_buildsjob resolvesuses: docker/setup-qemu-action@v4to that new commit the next time the workflow runs.Set up QEMUand can read files from the repository already fetched byactions/checkout@v6, inspect environment variables, and modify the runner state before the laterRun Buildxstep../prebuildsartifacts so theactions/upload-artifact@v7step publishes attacker-controlled build output.Because the reference here is
@v4instead of a full 40-character commit SHA, the exact code executed by this step can change without any workflow diff in this repository.To resolve this comment:
✨ Commit fix suggestion
View step-by-step instructions
Replace the mutable action reference with a full 40-character commit SHA instead of
@v4.Change
uses: docker/setup-qemu-action@v4touses: docker/setup-qemu-action@<full-40-character-commit-sha>.Get the SHA from the
docker/setup-qemu-actionrepository by opening thev4release or tag on GitHub and copying the commit hash for the exact revision you want to trust.The final value should look like
uses: docker/setup-qemu-action@8ade135a41bc03ea155e62e844d188df1ea18608.Add a short comment next to the pinned reference so future updates are intentional, for example
# docker/setup-qemu-action v4.Pinning to a commit SHA prevents the action owner from silently changing what runs under the same tag.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasonsAlternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag.
🛟 Help? Slack #semgrep-help or go/semgrep-help.
Resolution Options:
/fp $reason(if security gap doesn’t exist)/ar $reason(if gap is valid but intentional; add mitigations/monitoring)/other $reason(e.g., test-only)You can view more details about this finding in the Semgrep AppSec Platform.