Skip to content

fix: fix sunset ls to report all sunsetting versions of a resource#1196

Merged
andmatei merged 4 commits intomainfrom
fix-sunset-ls-multi-version
Apr 8, 2026
Merged

fix: fix sunset ls to report all sunsetting versions of a resource#1196
andmatei merged 4 commits intomainfrom
fix-sunset-ls-multi-version

Conversation

@andmatei
Copy link
Copy Markdown
Collaborator

@andmatei andmatei commented Apr 2, 2026

Summary

  • contentExtensions previously only returned extensions from the oldest API version, assuming older versions always have the earliest sunset date
  • This doesn't hold when newer versions have earlier sunsets (e.g. due to delayed older versions ensuring v1/v2 parity)
  • Now all content entries with an x-sunset extension are returned, so sunset ls lists every version with a sunset independently

Test plan

  • Updated unit tests for contentExtensions / successResponseExtensions to return []map[string]any
  • Added "Multiple versions with sunset extensions" test case to TestNewSunsetListFromSpec
  • Added "Content entry without sunset extension is skipped" test case
  • Existing TestList_Run integration test passes unchanged

@andmatei andmatei marked this pull request as ready for review April 8, 2026 12:09
@andmatei andmatei requested a review from a team as a code owner April 8, 2026 12:09
@andmatei andmatei merged commit 42c6f26 into main Apr 8, 2026
10 checks passed
@andmatei andmatei deleted the fix-sunset-ls-multi-version branch April 8, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants