[XCM-Transactor] Make fee_payer field optional in transact_through_sovereign - #2709
Merged
Conversation
…ides not being loaded
Contributor
Coverage Report@@ Coverage Diff @@
## master agustin-fee-payer-field +/- ##
===========================================================
- Coverage 72.51% 72.50% -0.01%
Files 229 229
+ Lines 70565 70651 +86
===========================================================
+ Hits 51164 51219 +55
+ Misses 19401 19432 +31
|
…agustin-fee-payer-field
Agusrodri
requested review from
RomarQ,
ahmadkaouk,
elfedy,
librelois and
noandrea
March 21, 2024 15:45
elfedy
approved these changes
Mar 21, 2024
ahmadkaouk
approved these changes
Mar 22, 2024
Contributor
|
Lets have this change rebased with master, you can create a new PR if you want to avoid a force push. |
Contributor
Author
Already rebased without force pushes :) |
RomarQ
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Changes
fee_payerfield type fromT::AccountIdtoOption<T::AccountId>. This allows root origin to avoid specifying a fee payer when executingtransact_through_sovereignfunction ofpallet-xcm-transactor.If
fee_payeris set toNone, the XCM execution fees will be paid by the sovereign account on the destination chain.Note
It's important to properly fund the sovereign account on destination with the corresponding amount that will be used to pay for execution fees, otherwise the call will fail or also there could be some funds mismatch.