Merged
Conversation
3d6525b to
8873c20
Compare
Contributor
Coverage Report@@ Coverage Diff @@
## master moonbeam-polkadot-v1.11.0 +/- ##
=============================================================
+ Coverage 81.23% 81.34% +0.11%
Files 301 301
+ Lines 85514 85698 +184
=============================================================
+ Hits 69462 69704 +242
- Misses 16052 15994 -58
|
RomarQ
requested changes
Jun 20, 2024
RomarQ
previously approved these changes
Jun 20, 2024
Collaborator
This PR is not in our polkadot-sdk fork branch moonbeam-polkadot-v1.11, I think it's fine to not include it, but then we should not mention it in the changes, @RomarQ do you agree? |
librelois
reviewed
Jun 24, 2024
Contributor
I agree, the change was reverted in paritytech/polkadot-sdk#4290 |
RomarQ
previously approved these changes
Jun 24, 2024
librelois
previously approved these changes
Jun 24, 2024
RomarQ
approved these changes
Jun 25, 2024
librelois
approved these changes
Jun 25, 2024
Agusrodri
approved these changes
Jun 25, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR updates polkadot-sdk from v1.7.2 to v1.11.0
What important points reviewers should know?
Polkadot-sdk
Replace
xcm_builder::V4V3LocationConverterWithLatestLocationConverterfor a more generic way to transition to new xcm versions Removexcm::v3fromassets-commonnits paritytech/polkadot-sdk#4037GenesisConfigpresetsGenesisConfigpresets for runtime paritytech/polkadot-sdk#2714GenesisBuilderAPI :MultiBLockmigrations Multi-Block-Migrations,pollhook and new System callbacks paritytech/polkadot-sdk#1781initialize_blocknow returnsExtrinsicInclusionModeto inform the Block Author whether they can push transactions.Configtrait offrame_systemhas 5 new items (set to default):impl frame_system::Config for Test { + type SingleBlockMigrations = (); + type MultiBlockMigrator = (); + type PreInherents = (); + type PostInherents = (); + type PostTransactions = (); }Add HRMP notification handlers to the xcm-executor Add HRMP notification handlers to the xcm-executor paritytech/polkadot-sdk#3696:
Configtrait ofxcm_executorhas 3 new items (set to default):impl xcm_executor::Config for Test { + type HrmpNewChannelOpenRequestHandler = (); + type HrmpChannelAcceptedHandler = (); + type HrmpChannelClosingHandler = (); }Allow to process incoming xcm messages enqueud in the same block on_idle process enqueued messages on idle paritytech/polkadot-sdk#3844
IdleMaxServiceWeightis added on the message-queueConfigtraitFrontier
OverrideHandlewithStorageOverrideHandlerrefactor: storage override polkadot-evm/frontier#1425CallRequestandTransactionRequestin the same type Merge CallRequst and TransactionRequest RPC types polkadot-evm/frontier#1301Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
Polkadot-sdk
bench pallet: only requireHashinstead ofBlockparitytech/polkadot-sdk#3244TryRuntimesubcommand paritytech/polkadot-sdk#4017claim_assetsextrinsic topallet-xcmparitytech/polkadot-sdk#3403What value does it bring to the blockchain users?