Conversation
Contributor
Coverage Report@@ Coverage Diff @@
## master agustin-xcm-payment-api +/- ##
===========================================================
+ Coverage 81.10% 81.26% +0.16%
+ Files 274 301 +27
+ Lines 80576 85781 +5205
===========================================================
+ Hits 65348 69704 +4356
+ Misses 15228 16077 +849
|
RomarQ
requested changes
Jul 4, 2024
Contributor
|
About the test, could we use the fees calculated and do an xcm call to make sure the estimated value is enough? |
librelois
previously approved these changes
Jul 5, 2024
Contributor
Author
RomarQ
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds the new runtime API called
XcmPaymentApi, which allows to fetch the following information:weight-to-assetfee conversion (as long as the indicated asset is allowed to be used for execution payment).More context on: paritytech/polkadot-sdk#3607