Skip to content

make abort panic with msg under js target#3426

Open
hackwaly wants to merge 1 commit intomainfrom
yuxiang/js-panic-with-msg
Open

make abort panic with msg under js target#3426
hackwaly wants to merge 1 commit intomainfrom
yuxiang/js-panic-with-msg

Conversation

@hackwaly
Copy link
Copy Markdown
Contributor

@hackwaly hackwaly commented Apr 14, 2026

This PR changes the behavior of abort under js target: Let the msg visible to end users.


Open with Devin

@hackwaly hackwaly requested a review from bobzhang April 14, 2026 17:28
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 14, 2026

Coverage Report for CI Build 3784

Coverage remained the same at 95.003%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15428
Covered Lines: 14657
Line Coverage: 95.0%
Coverage Strength: 220060.29 hits per line

💛 - Coveralls

@hackwaly hackwaly force-pushed the yuxiang/js-panic-with-msg branch from ae508e4 to 251c4d5 Compare April 15, 2026 00:58
@peter-jerry-ye
Copy link
Copy Markdown
Collaborator

We should make abort as primitive.

@hackwaly
Copy link
Copy Markdown
Contributor Author

Maybe panic with Option[String] message is better? AI often assumes panic have a message parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants