refactor: convert more array-building loops to for-comprehensions#3447
Closed
refactor: convert more array-building loops to for-comprehensions#3447
Conversation
Third follow-up to #3444, applying the pattern more aggressively: - argparse/parser_positionals.mbt: positional_args - hashset/hashset.mbt: HashSet::to_array (drops explicit capacity hint) - immut/sorted_set/immutable_set.mbt: ToJson impl - list/list.mbt: ToJson impl - sorted_map/deprecated.mbt: keys, values (uses Iter2 two-binding for) - sorted_map/map.mbt: to_array Array comprehensions do not allow calling functions that can raise, so Array::filter, Array::filter_map, and their ArrayView counterparts are left untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Coverage Report for CI Build 3876Coverage decreased (-0.004%) to 94.91%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
4 tasks
Contributor
Author
|
Superseded by #3448 which consolidates all comprehension refactors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth in the series (after #3444, #3445, #3446). Aggressive sweep targeting sites where the comprehension form is clearly more concise, even when it drops an explicit `capacity` pre-alloc hint:
Discovered limitation
Array comprehensions reject calling functions that can raise ("calling function with error is not allowed inside list comprehension"). This blocks conversion of `Array::filter`, `Array::filter_map`, `ArrayView::filter`, `ArrayView::filter_map`, etc., which take `(T) -> Bool raise?` predicates. Those are left untouched.
Test plan
🤖 Generated with Claude Code