Skip to content

use list comprehension in more ToJson impls#3451

Open
bobzhang wants to merge 5 commits intomainfrom
hongbo/tweak_list
Open

use list comprehension in more ToJson impls#3451
bobzhang wants to merge 5 commits intomainfrom
hongbo/tweak_list

Conversation

@bobzhang
Copy link
Copy Markdown
Contributor

@bobzhang bobzhang commented Apr 22, 2026

Summary

  • Simplify ToJson implementations across hashset, list, set, deque, priority_queue, immut/priority_queue, and immut/sorted_set to use list comprehension syntax
  • Update immut/vector test to use list comprehension
  • Follow-up to use list comprehension in ToJson impls #3450

Test plan

  • CI passes

🤖 Generated with Claude Code


Open in Devin Review

bobzhang and others added 3 commits April 22, 2026 09:20
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 22, 2026

Coverage Report for CI Build 3886

Coverage decreased (-0.002%) to 94.907%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: 10 of 10 lines across 9 files are fully covered (100%).
  • 3 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
immut/vector/vector.mbt 3 92.48%

Coverage Stats

Coverage Status
Relevant Lines: 15510
Covered Lines: 14720
Line Coverage: 94.91%
Coverage Strength: 220531.03 hits per line

💛 - Coveralls

bobzhang and others added 2 commits April 22, 2026 09:41
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants