support tracks without a valid duration, e.g. musepack#70
Open
schmaller wants to merge 4 commits into
Open
Conversation
txomon
reviewed
Feb 14, 2023
txomon
left a comment
txomon
left a comment
There was a problem hiding this comment.
Thanks for your PR! Do you think we could add a sample file or maybe a test of the happy paths?
txomon
reviewed
Feb 14, 2023
| "No duration information found in file" | ||
| ) | ||
| elif result.duration < MIN_DURATION_MS: | ||
| elif result.duration and result.duration < MIN_DURATION_MS: |
There was a problem hiding this comment.
Just in case, this change will now let duration 0 pass and skip through all checks because it's not None and it's falsey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For .mpc files the Scanner..scan() from mopidy.audio doesn't return a valid duration
which prevents these files from getting into the library.
However, those files can be played by gstreamer without any problems.
My change handles this "violation" less strictly and accepts files without a duration to be put into the library.