pbr-1.2.2: bump PKG_RELEASE from 20 to 22 - #154
Merged
Conversation
Lockstep release bump with luci-app-pbr. Covers the /etc/pbr/ path rewrite fix (#131, fixes #130), xfrm/IPsec interface support (#140) and the fw4 chain flush fix (#145). Compat is unchanged at 27 — nothing since release 20 touched the message catalog. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Erik Conijn <egc112@msn.com>
Collaborator
Author
|
Co_pilot comment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in release 22
Fixed: pbr could knock out LAN forwarding and port forwards.
When rebuilding its rules, pbr flushed the firewall's own
forward,dstnat,preroutingandoutputchains instead of its own — wiping fw4's zone jumps and port forwards. Normally a reload seconds later papered over it, but if that reload was skipped because the new ruleset failed validation, the outage stayed. Sinceforward's default policy is drop, that meant no LAN↔WAN traffic at all. Backport of the fix already in 1.2.3.Fixed: custom script paths no longer rewritten on upgrade.
Scripts kept in
/etc/pbr/had their paths silently rewritten to/usr/share/pbr/on every upgrade, so after a sysupgrade they stopped being found. (#130)IPsec/xfrm interfaces are now recognised. They count as tunnel interfaces like WireGuard and OpenVPN, and point-to-point detection is now done the same way everywhere — so no more spurious "unknown gateway" warnings on those interfaces.
Fixed in the WebUI: your resolver set choice is no longer lost when you hit Save.
Only affects LuCI master/snapshot builds at the moment — stable releases do not yet carry the luci-base change that triggers it, so on 24.10 and 25.12 you are unaffected. On master, the first Save on the overview page deleted the provisioned
resolver_setvalue, silently turning resolver set support off while the WebUI still showed it enabled, and domain policies quietly fell back to one-off lookups. On 1.2.2 nothing restored it afterwards, so it stayed off. This fix lands ahead of that change reaching stable. Thanks to @pesa1234 for spotting it.Release/packaging. apk files keep their
rrelease prefix so downloads match locally built ones, stale release assets are pruned, the SDK is pinned to stable point releases, and new releases now sync to repo.mossdef.org immediately instead of waiting for the hourly poll.The compatibility number is unchanged at 27 — nothing since release 20 touched the message catalog, so no forced pairing this time. Both packages are released together as usual.
pbr commits since 20: #131
/etc/pbr/path rewrite (fixes #130) · #140 xfrm/IPsec interface support · #145 fw4 chain flush fix · maintainer metadataluci-app-pbr commits since 20: mossdef-org/luci-app-pbr#38 resolver_set preserved on save · release workflow and packaging fixes · maintainer metadata
Pairs with the luci-app-pbr 1.2.2 bump to 22; both should land together.