Bugfix FXIOS-15389 [Translations][Accessibility] Languages cannot be removed from the Preferred Languages section with voice-over ON#32992
Conversation
✍️ Strings UpdatedDetected changes in 🧹 Tidy commitJust 3 file(s) touched. Thanks for keeping it clean and review-friendly! ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.41
Generated by 🚫 Danger Swift against 5412fc6 |
|
This pull request has conflicts when rebasing. Could you fix it @razvanlitianu? 🙏 |
ab3ab69 to
0f1e340
Compare
… announce or remove preferred languages in edit mode
0f1e340 to
101de22
Compare
thatswinnie
left a comment
There was a problem hiding this comment.
I did some testing and while the solution works it's not in line with how Apple implemented it in their own apps. It would be unexpected to the user if they delete a language on an action that should activate the cell. Instead we should add an UIAccessibilityCustomAction to the cell that allows for the deletion.
…ith UIAccessibilityCustomAction for preferred language deletion
|
@thatswinnie |
| value: "Add Language…", | ||
| comment: "Row label in the preferred languages list that opens the language picker to add a new preferred language for translation." | ||
| ) | ||
| public static let RemoveLanguageA11yAction = MZLocalizedString( |
There was a problem hiding this comment.
With this being a new string the feature shouldn't be made available to the end user until v151. Can you can confirm that this is behind a feature flag and no experiment will be running for this until v151?
There was a problem hiding this comment.
That's correct. The feature flag is .translationLanguagePicker.
|
🚀 PR merged to |
📜 Tickets
Jira ticket
Github issue
💡 Description
🎥 Demos
ScreenRecording_04-09-2026.10-35-28_1.mp4
Demo
📝 Checklist