Skip to content

Bugfix FXIOS-14985 Status bar overlay is strangely animated when we start a search #33046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MartinP7r wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −3
Draft

Bugfix FXIOS-14985 Status bar overlay is strangely animated when we start a search #33046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871a0c6
empty commit
MartinP7r Apr 13, 2026
26fd4dd
Bugfix #32283 [Status bar] Prevent keyboard animation context leak in…
MartinP7r Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5059,7 +5059,14 @@ extension BrowserViewController: KeyboardHelperDelegate {
// When animation duration is zero the keyboard is already showing and we don't need
// to update the toolbar again. This is the case when we are moving between fields in a form.
if state.animationDuration > 0 {
updateToolbarDisplay()
// Use performWithoutAnimation to prevent the keyboard's animation context
// from leaking into updateToolbarDisplay. Without this, the keyboard's
// animation curve captures property changes on the status bar overlay and
// blur views, causing a visible left-to-right fill artifact with UIGlassEffect
// on iOS 26+. (See: https://github.com/nickmilo/firefox-ios/issues/32283)
Copy link
Copy Markdown
Contributor

@yoanarios yoanarios Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The link leads to a page not found 404 so I suggest to remove it

Suggested change
// on iOS 26+. (See: https://github.com/nickmilo/firefox-ios/issues/32283)
// on iOS 26+.

UIView.performWithoutAnimation {
self.updateToolbarDisplay()
}
}
} else {
updateToolbarDisplay()
Expand Down Expand Up @@ -5094,8 +5101,11 @@ extension BrowserViewController: KeyboardHelperDelegate {

cancelEditingMode()
if isToolbarTranslucencyRefactorEnabled {
updateBlurViews()
addOrUpdateMaskViewIfNeeded()
// Prevent keyboard animation context leak (same as keyboardWillShow fix)
UIView.performWithoutAnimation {
self.updateBlurViews()
self.addOrUpdateMaskViewIfNeeded()
}
} else {
updateToolbarDisplay()
}
Expand Down
Loading