Skip to content

Refactor FXIOS-15359 [Technical Debt] [Redux] Use @CopyWithUpdates macro for NativeErrorPageState#33048

Open
satomasahiro2005 wants to merge 1 commit intomozilla-mobile:mainfrom
satomasahiro2005:fix/FXIOS-15358-native-error-page-state-copy-with-updates
Open

Refactor FXIOS-15359 [Technical Debt] [Redux] Use @CopyWithUpdates macro for NativeErrorPageState#33048
satomasahiro2005 wants to merge 1 commit intomozilla-mobile:mainfrom
satomasahiro2005:fix/FXIOS-15358-native-error-page-state-copy-with-updates

Conversation

@satomasahiro2005
Copy link
Copy Markdown

@satomasahiro2005 satomasahiro2005 commented Apr 13, 2026

📜 Tickets

Jira ticket
Github issue

💡 Description

Applies the @CopyWithUpdates Swift macro to NativeErrorPageState, replacing manual state construction in the reducer and defaultState with state.copyWithUpdates(...) calls.

Only properties that change need to be passed, reducing boilerplate. For reference, see #32214 which applied the same pattern to HomepageState.

No UI, telemetry, or string changes are included in this PR.

🎥 Demos

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@satomasahiro2005 satomasahiro2005 requested a review from a team as a code owner April 13, 2026 15:31
@satomasahiro2005 satomasahiro2005 changed the title Refactor FXIOS-15359 [Technical Debt] [Redux] Apply @CopyWithUpdates to NativeErrorPageState Refactor FXIOS-15359: [Redux] Use @CopyWithUpdates macro for NativeErrorPageState Apr 13, 2026
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 41.03%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.45

File Coverage
NativeErrorPageState.swift 92.73%

Generated by 🚫 Danger Swift against b99dea5

@satomasahiro2005 satomasahiro2005 changed the title Refactor FXIOS-15359: [Redux] Use @CopyWithUpdates macro for NativeErrorPageState Refactor FXIOS-15359 [Technical Debt] [Redux] Use @CopyWithUpdates macro for NativeErrorPageState Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants