Refactor FXIOS-15359 [Technical Debt] [Redux] Use @CopyWithUpdates macro for NativeErrorPageState#33048
Open
satomasahiro2005 wants to merge 1 commit intomozilla-mobile:mainfrom
Conversation
…to NativeErrorPageState
🧹 Tidy commitJust 1 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.45
Generated by 🚫 Danger Swift against b99dea5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Applies the
@CopyWithUpdatesSwift macro toNativeErrorPageState, replacing manual state construction in the reducer anddefaultStatewithstate.copyWithUpdates(...)calls.Only properties that change need to be passed, reducing boilerplate. For reference, see #32214 which applied the same pattern to
HomepageState.No UI, telemetry, or string changes are included in this PR.
🎥 Demos
📝 Checklist