Refactor FXIOS-15074 ⁃ [Tracking Protection] Use native navigation bar#33067
Refactor FXIOS-15074 ⁃ [Tracking Protection] Use native navigation bar#33067dicarobinho wants to merge 2 commits intomainfrom
Conversation
🧩 Neat PieceThis PR changes 513 lines. It's a substantial update, 🌟 Documentation starGreat documentation touches. Future you says thank you! 📚 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.45
Generated by 🚫 Danger Swift against d24b574 |
thatswinnie
left a comment
thatswinnie
left a comment
There was a problem hiding this comment.
The sizes of the close button is different - can we adjust this so both are the same?
 |
 |
| view.accessibilityIdentifier = A11yIds.containerView | ||
| } | ||
|
|
||
| private lazy var closeButton: UIButton = .build { |
There was a problem hiding this comment.
I think we should use CloseButton from our component library here instead of configuring a UIButton ourselves.
| // MARK: Navigation View | ||
| private let navigationView: NavigationHeaderView = .build { header in | ||
| header.accessibilityIdentifier = AccessibilityIdentifiers.EnhancedTrackingProtection.BlockedTrackers.headerView | ||
| private lazy var closeButton: UIButton = .build { |
There was a problem hiding this comment.
Same here: we should use CloseButton from our component library here.
| tableView.separatorInset = .zero | ||
| } | ||
|
|
||
| private lazy var closeButton: UIButton = .build { |
There was a problem hiding this comment.
Same here: we should use CloseButton from our component library here.
| view.accessibilityIdentifier = AccessibilityIdentifiers.EnhancedTrackingProtection.DetailsScreen.verifiedByView | ||
| } | ||
|
|
||
| private lazy var closeButton: UIButton = .build { |
There was a problem hiding this comment.
Same here: we should use CloseButton from our component library here.
|
Using custom Important note: for the main Tracking Protection screen, we are using a custom ScreenRecording_04-16-2026.10-11-49_1.MP4 |
3 participants
📜 Tickets
Jira ticket
Github issue
💡 Description
Removed NavigationHeader component
Using native navigation bar for Tracking Protection screens
🎥 Demos
ScreenRecording_04-08-2026.15-00-42_1.mp4
Demo
📝 Checklist