Refactor FXIOS-15257 [Translations Phase 2] Split language edit mode into a dedicated screen#33086
Open
razvanlitianu wants to merge 1 commit intomainfrom
Open
Refactor FXIOS-15257 [Translations Phase 2] Split language edit mode into a dedicated screen#33086razvanlitianu wants to merge 1 commit intomainfrom
razvanlitianu wants to merge 1 commit intomainfrom
Conversation
💪 Quality guardian3 tests files modified. You're a champion of test coverage! 🚀 🧩 Neat PieceThis PR changes 778 lines. It's a substantial update, 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ New file code coverageAll new files meet their thresholds**. Client.app: Coverage: 39.43
Generated by 🚫 Danger Swift against b8f4eb7 |
razvanlitianu
force-pushed
the
rlitianu/translations-settings-language-edit-v2
branch
5 times, most recently
from
a9aed08 to
53335a5
Compare
razvanlitianu
force-pushed
the
rlitianu/translations-settings-language-edit-v2
branch
from
53335a5 to
d98bf37
Compare
…into a dedicated screen Move language reordering and deletion out of the inline edit mode on the Translation Settings screen and into a new TranslationLanguageEditViewController pushed onto the navigation stack. Edit state is now fully local to the edit screen; Redux state is updated only when the user taps Done.
razvanlitianu
force-pushed
the
rlitianu/translations-settings-language-edit-v2
branch
from
d98bf37 to
b8f4eb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Move language reordering and deletion out of the inline edit mode on the Translation Settings screen and into a new TranslationLanguageEditViewController pushed onto the navigation stack. Edit state is now fully local to the edit screen; Redux state is updated only when the user taps Done. Also adds an unsupported-device-language disabled row for devices whose language has no translation model available.
🎥 Demos
Demo
📝 Checklist