Skip to content

Refactor NOTICKET Rename Story Cell #33117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adudenamedruby merged 1 commit into from
Apr 16, 2026
Merged

Refactor NOTICKET Rename Story Cell #33117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions firefox-ios/Client.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,7 @@
C79CF6B22EE0E593004C4EB8 /* BookmarksCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = C79CF6B12EE0E590004C4EB8 /* BookmarksCell.swift */; };
C7A492742EBE78D00098845C /* DismissalNotifiable.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7A492732EBE78CA0098845C /* DismissalNotifiable.swift */; };
C7A492762EBE817D0098845C /* MockDismissalNotifiableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7A492752EBE81770098845C /* MockDismissalNotifiableViewController.swift */; };
C7B376E32E870173006B2D32 /* StoryCellLarge.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7B376E22E870173006B2D32 /* StoryCellLarge.swift */; };
C7B376E32E870173006B2D32 /* StoryCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7B376E22E870173006B2D32 /* StoryCell.swift */; };
C7CDBEFD2CE6926900826A92 /* BookmarksFolderEmptyStateView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7CDBEFC2CE6926900826A92 /* BookmarksFolderEmptyStateView.swift */; };
C7F051522D95EACF00EC52C0 /* HistoryDeletionUtilityTelemetry.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7F051512D95EACF00EC52C0 /* HistoryDeletionUtilityTelemetry.swift */; };
C7F051562D9EF87D00EC52C0 /* ContextMenuTelemetry.swift in Sources */ = {isa = PBXBuildFile; fileRef = C7F051552D9EF87D00EC52C0 /* ContextMenuTelemetry.swift */; };
Expand Down Expand Up @@ -10284,7 +10284,7 @@
C7A492732EBE78CA0098845C /* DismissalNotifiable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DismissalNotifiable.swift; sourceTree = "<group>"; };
C7A492752EBE81770098845C /* MockDismissalNotifiableViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockDismissalNotifiableViewController.swift; sourceTree = "<group>"; };
C7A6413B89FE82B94F735FFD /* gl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = gl; path = gl.lproj/ClearHistoryConfirm.strings; sourceTree = "<group>"; };
C7B376E22E870173006B2D32 /* StoryCellLarge.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoryCellLarge.swift; sourceTree = "<group>"; };
C7B376E22E870173006B2D32 /* StoryCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StoryCell.swift; sourceTree = "<group>"; };
C7C54345A164D550CF2BC575 /* kn */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = kn; path = kn.lproj/3DTouchActions.strings; sourceTree = "<group>"; };
C7CDBEFC2CE6926900826A92 /* BookmarksFolderEmptyStateView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookmarksFolderEmptyStateView.swift; sourceTree = "<group>"; };
C7D341F8BA6A9E44518C11C8 /* oc */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = oc; path = oc.lproj/3DTouchActions.strings; sourceTree = "<group>"; };
Expand Down Expand Up @@ -14914,7 +14914,7 @@
C7D7362F2E85DC73000ECE41 /* StoriesFeed */ = {
isa = PBXGroup;
children = (
C7B376E22E870173006B2D32 /* StoryCellLarge.swift */,
C7B376E22E870173006B2D32 /* StoryCell.swift */,
);
path = StoriesFeed;
sourceTree = "<group>";
Expand Down Expand Up @@ -19301,7 +19301,7 @@
23ED80FF25C89C9800D0E9D5 /* DefaultBrowserOnboardingViewController.swift in Sources */,
8A3EF80D2A2FD04D00796E3A /* ResetWallpaperOnboardingPage.swift in Sources */,
E1FE132F29C0B3CB002A65FF /* NotificationSurfaceManager.swift in Sources */,
C7B376E32E870173006B2D32 /* StoryCellLarge.swift in Sources */,
C7B376E32E870173006B2D32 /* StoryCell.swift in Sources */,
D88FDA9F1F4E2B9200FD9709 /* PhotonActionSheetProtocol.swift in Sources */,
5AD3B67C2CF65DE600AFA1FE /* LocaleProvider.swift in Sources */,
1D5A117A2EAEC51100DD27F7 /* ResetSearchEnginePrefsSetting.swift in Sources */,
Expand Down
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/Home/Homepage/HomepageDiffableDataSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ final class HomepageDiffableDataSource:
JumpBackInCell.self,
SyncedTabCell.self,
BookmarksCell.self,
StoryCellLarge.self,
StoryCell.self,
HomepageSpacerCell.self
]
}
Expand Down
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/Home/Homepage/HomepageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ final class HomepageViewController: UIViewController,
let currentSection = dataSource?.snapshot().sectionIdentifiers[indexPath.section] ?? .pocket(.clear)
let totalCount = dataSource?.snapshot().numberOfItems(inSection: currentSection)

return configuredCell(cellType: StoryCellLarge.self, at: indexPath) { cell in
return configuredCell(cellType: StoryCell.self, at: indexPath) { cell in
cell.configure(story: story, theme: currentTheme, position: position, totalCount: totalCount)
}
}
Expand Down
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/Home/Homepage/Merino/MerinoStoryConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import Foundation

/// Converts the Merino story model to be presentable for the `StoryCellLarge` view
/// Converts the Merino story model to be presentable for the `StoryCell` view
final class MerinoStoryConfiguration: Sendable, Equatable, Hashable {
private let story: MerinoStory

Expand Down
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/Home/Homepage/Merino/MerinoStoryResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import Foundation

/// Converts the Merino story model to be presentable for the `StoryCellLarge` view
/// Converts the Merino story model to be presentable for the `StoryCell` view
final class MerinoStoryResponse: Sendable, Equatable, Hashable {
let stories: [MerinoStoryConfiguration]?
let categories: [MerinoCategoryConfiguration]?
Expand Down
2 changes: 1 addition & 1 deletion ...Frontend/StoriesFeed/StoryCellLarge.swift → ...ient/Frontend/StoriesFeed/StoryCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Common
import Foundation
import SiteImageView

class StoryCellLarge: UICollectionViewCell,
class StoryCell: UICollectionViewCell,
ReusableCell,
Notifiable,
ThemeApplicable {
Expand Down
Loading