Skip to content

Add FXIOS-15434 [Newsfeed Categories] Merino categories test data#33118

Merged
Foxbolts merged 1 commit intomainfrom
fb/FXIOS-15434_merino-category-test-data
Apr 16, 2026
Merged

Add FXIOS-15434 [Newsfeed Categories] Merino categories test data#33118
Foxbolts merged 1 commit intomainfrom
fb/FXIOS-15434_merino-category-test-data

Conversation

@Foxbolts
Copy link
Copy Markdown
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add mock data for Merino categories
    • Mock data is used for tests and to display categories on the homepage in developer builds

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@Foxbolts Foxbolts requested a review from adudenamedruby April 15, 2026 21:20
@Foxbolts Foxbolts requested a review from a team as a code owner April 15, 2026 21:20
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 41.23%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 3 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.57

File Coverage
MerinoProvider.swift 89.22%
MerinoTestData.swift 99.5%

Generated by 🚫 Danger Swift against 3c233e5

Copy link
Copy Markdown
Contributor

@adudenamedruby adudenamedruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Foxbolts Foxbolts merged commit 433d254 into main Apr 16, 2026
9 checks passed
@Foxbolts Foxbolts deleted the fb/FXIOS-15434_merino-category-test-data branch April 16, 2026 14:36
@github-actions
Copy link
Copy Markdown
Contributor

🚀 PR merged to main, targeting version: 150.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants