[DISCO-4064] Resolve naming conflict and update suggest options#7322
Open
misaniwere wants to merge 3 commits intomainfrom
Open
[DISCO-4064] Resolve naming conflict and update suggest options#7322misaniwere wants to merge 3 commits intomainfrom
misaniwere wants to merge 3 commits intomainfrom
Conversation
tiftran
reviewed
Apr 16, 2026
| options: SuggestOptions, | ||
| endpoint_url: &Url, | ||
| ) -> Result<viaduct::Response> { | ||
| let providers = options.providers.map(|v| v.join(",")); |
Contributor
There was a problem hiding this comment.
just an edge case concern. Would we ever get an empty vec? This would result an empty string, I think?
Asking because https://merino.services.mozilla.com/api/v1/suggest?q=ama&providers="" doesn't return anything
Contributor
Author
There was a problem hiding this comment.
good catch! i'll handle that case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DISCO-4064]
SuggestApiError→MerinoSuggestApiErrorto avoid a naming conflict with the existing suggest component, which was breaking the Swift docs CI pipeline.SuggestOptions,providersandclient_variantsnow expect a list of strings as it's easier for the consumers. These values are joined as comma-separated values when sent to Merino.Pull Request checklist
[ci full]to the PR title.