Skip to content

Fixes #2554 Updated remaining uses of Courier to Courier New #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcobeltempo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #2554 Updated remaining uses of Courier to Courier New #896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb182e
Add font family "Courier New" to fix rendering issues
marcobeltempo Nov 24, 2017
a783651
Fixed css property styling
marcobeltempo Dec 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/extensions/default/bramble/stylesheets/consoleTheme.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
box-shadow: none;
display: block;
font-size: 15px;
font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed;
font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', 'Courier New', Courier, monospace, fixed;
user-select: text;
color: black;
transform-origin: 15% 50%;
Expand All @@ -28,7 +28,7 @@

#editor-console .console .helper {
font-size: 15px;
font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed;
font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', 'Courier New', Courier, monospace, fixed;
display: none;
color: black;
position: absolute;
Expand Down
8 changes: 4 additions & 4 deletions src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,15 +263,15 @@ span.brackets-js-hints-with-type-details {

.brackets-js-hints.literal-hint {
color: #444; /* dark grey */
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", "Courier New", Courier, monospace, fixed;
}

.brackets-js-hints.keyword-hint {
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", "Courier New", Courier, monospace, fixed;
}

.brackets-js-hints.keyword-hint .matched-hint {
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", "Courier New", Courier, monospace, fixed;
font-weight: 500;
}

Expand Down Expand Up @@ -327,7 +327,7 @@ span.brackets-js-hints-with-type-details {

.dark .brackets-js-hints.literal-hint {
color: #bbb; /* dark grey */
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, fixed;
font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", "Courier New", Courier, monospace, fixed;
}

.dark #function-hint-container {
Expand Down
5 changes: 4 additions & 1 deletion src/extensions/extra/PDFView/styles/viewer-overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ body {
color: rgba(0,0,0,.7);
}


#pdf-page-count {
position: relative;
padding-right: 16px;
Expand All @@ -47,6 +46,10 @@ body {
background-repeat: no-repeat;
}

#PDFBug .stats {
font-family: "Courier New", Courier, monospace !important;
Copy link
Copy Markdown

@flukeout flukeout Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, could you please indent this line to match the rest of the stylesheet?

Copy link
Copy Markdown
Author

@marcobeltempo marcobeltempo Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh good eye @flukeout Just fixed it

}

.dark-theme #pdf-page-count:after {
background-image: url("../images/file-white.svg");
}
Expand Down
2 changes: 1 addition & 1 deletion src/view/ViewCommandHandlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ define(function (require, exports, module) {
* The default font family
* @type {string}
*/
var DEFAULT_FONT_FAMILY = "'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed";
var DEFAULT_FONT_FAMILY = "'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', 'Courier New', Courier, monospace, fixed";

/**
* @private
Expand Down