Skip to content

Do not assume char is always signed#61

Open
erik-hallberg wants to merge 2 commits intompaland:masterfrom
erik-hallberg:signed-char
Open

Do not assume char is always signed#61
erik-hallberg wants to merge 2 commits intompaland:masterfrom
erik-hallberg:signed-char

Conversation

@erik-hallberg
Copy link
Copy Markdown

This is platform-dependent and having it wrong makes the PRId8 and PRIi8 macros print int8_t values as unsigned on some platforms.

This is platform-dependent and having it wrong makes the PRId8 and
PRIi8 macros print int8_t values as unsigned on some platforms.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 5, 2019

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         359    359           
=====================================
  Hits          359    359
Impacted Files Coverage Δ
printf.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21eea6c...eb3bc62. Read the comment docs.

@dublevskyi
Copy link
Copy Markdown

Can you please merge the PR? @mpaland

@eyalroz
Copy link
Copy Markdown
Collaborator

eyalroz commented Jun 28, 2021

@dublevskyi : I've merged this into my fork, which is basically a merge of a bunch of small changes and fixes people have suggested.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@21eea6c). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             master       #61   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         1           
  Lines             ?       359           
  Branches          ?         0           
==========================================
  Hits              ?       359           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants