Do not assume char is always signed#61
Conversation
This is platform-dependent and having it wrong makes the PRId8 and PRIi8 macros print int8_t values as unsigned on some platforms.
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 359 359
=====================================
Hits 359 359
Continue to review full report at Codecov.
|
|
Can you please merge the PR? @mpaland |
|
@dublevskyi : I've merged this into my fork, which is basically a merge of a bunch of small changes and fixes people have suggested. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 1
Lines ? 359
Branches ? 0
==========================================
Hits ? 359
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is platform-dependent and having it wrong makes the PRId8 and PRIi8 macros print int8_t values as unsigned on some platforms.