Skip to content

Extract a struct for building bitmaps#405

Open
zebmason wants to merge 1 commit into
mrc-ide:masterfrom
zebmason:bitmap
Open

Extract a struct for building bitmaps#405
zebmason wants to merge 1 commit into
mrc-ide:masterfrom
zebmason:bitmap

Conversation

@zebmason

Copy link
Copy Markdown
Contributor

First pass tidy up as seen in the video referenced in #403

Comment thread src/Bitmap.cpp

@matt-gretton-dann matt-gretton-dann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR doesn't go far enough. Bitmap handling is probably one of the most easily abstracted out parts of the code.

My expectation is that the only interface that needs to be exposed to the main part of the model is:


// some enums...

class BitmapBuilder
{
public:
   BitmapBuilder(/* Init stuff */);
   void record_activity(type, position);
   void output(filename, format) const;
};

See #399 for some recent changes which I think we could take further as population/infected/recovered/treated could be converted into enums themselves.

@zebmason

Copy link
Copy Markdown
Contributor Author

@matt-gretton-dann Just a first pass as I'm wary about trying to get changes accepted given that I've had several PRs just rotting for over a month leaving really bad merge conflicts to get resolved.

@zebmason zebmason force-pushed the bitmap branch 2 times, most recently from 93b5ee8 to 1cb50d6 Compare June 23, 2020 21:21
@zebmason zebmason requested a review from weshinsley as a code owner June 23, 2020 21:21
@zebmason zebmason force-pushed the bitmap branch 5 times, most recently from 8e92aea to 3b1eb68 Compare June 26, 2020 06:34
@zebmason zebmason force-pushed the bitmap branch 2 times, most recently from b3c42d5 to 0827afb Compare July 9, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants