Extract a struct for building bitmaps#405
Open
zebmason wants to merge 1 commit into
Open
Conversation
zlatanvasovic
approved these changes
Jun 19, 2020
matt-gretton-dann
left a comment
Collaborator
There was a problem hiding this comment.
I think this PR doesn't go far enough. Bitmap handling is probably one of the most easily abstracted out parts of the code.
My expectation is that the only interface that needs to be exposed to the main part of the model is:
// some enums...
class BitmapBuilder
{
public:
BitmapBuilder(/* Init stuff */);
void record_activity(type, position);
void output(filename, format) const;
};
See #399 for some recent changes which I think we could take further as population/infected/recovered/treated could be converted into enums themselves.
Contributor
Author
|
@matt-gretton-dann Just a first pass as I'm wary about trying to get changes accepted given that I've had several PRs just rotting for over a month leaving really bad merge conflicts to get resolved. |
93b5ee8 to
1cb50d6
Compare
8e92aea to
3b1eb68
Compare
b3c42d5 to
0827afb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass tidy up as seen in the video referenced in #403