Pull out separate functions for reading files in SetupModel.cpp#426
Open
ZedThree wants to merge 3 commits into
Open
Pull out separate functions for reading files in SetupModel.cpp#426ZedThree wants to merge 3 commits into
ZedThree wants to merge 3 commits into
Conversation
ZedThree
requested review from
NeilFerguson,
Z80coder,
dlaydon,
gnedjati,
igfoo,
matt-gretton-dann and
weshinsley
as code owners
matt-gretton-dann
requested changes
Jun 24, 2020
matt-gretton-dann
left a comment
matt-gretton-dann
left a comment
Collaborator
There was a problem hiding this comment.
A couple of small changes (which I acknowledge include things that increase the scope but I believe are important).
A future PR should change the types in the BinFile format to be fixed type sizes.
ZedThree
force-pushed
the
separate_file_read_functions
branch
from
0a80255 to
20bfa4f
Compare
Author
|
Rebased to resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal changes besides pulling out the bits of the code for reading the data files into separate functions. Reduced scope of some local variables, added
constexpr auto binary_density_file_magic_numberas it's used in a couple of places.I did also apply clang-format to the new functions using the config file in #397