Skip to content

WebGPURenderer: Premultiply in sRGB color space #33329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
WestLangley wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

WebGPURenderer: Premultiply in sRGB color space #33329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/nodes/display/ColorSpaceNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import TempNode from '../core/TempNode.js';
import { addMethodChaining, mat3, nodeObject, vec4 } from '../tsl/TSLCore.js';
import { addMethodChaining, mat3, nodeObject, vec3, vec4 } from '../tsl/TSLCore.js';

import { SRGBTransfer } from '../../constants.js';
import { ColorManagement } from '../../math/ColorManagement.js';
import { sRGBTransferEOTF, sRGBTransferOETF } from './ColorSpaceFunctions.js';
import { Matrix3 } from '../../math/Matrix3.js';
import { clamp } from '../math/MathNode.js';

const WORKING_COLOR_SPACE = 'WorkingColorSpace';
const OUTPUT_COLOR_SPACE = 'OutputColorSpace';
Expand Down Expand Up @@ -114,8 +115,20 @@ class ColorSpaceNode extends TempNode {

if ( ColorManagement.getTransfer( target ) === SRGBTransfer ) {

// premultiply in sRGB color space for the HTML compositor #33104

// un-premultiply in linear space
outputNode = vec4( outputNode.a.greaterThan( 0.0 ).select( outputNode.rgb.div( outputNode.a ), vec3( 0.0 ) ), outputNode.a );

// clamp RGB to [ 0,1 ]
outputNode = vec4( clamp( outputNode.rgb, 0.0, 1.0 ), outputNode.a );

// encode to sRGB
outputNode = vec4( sRGBTransferOETF( outputNode.rgb ), outputNode.a );

// premultiply in sRGB color space
outputNode = vec4( outputNode.rgb.mul( outputNode.a ), outputNode.a );

}

return outputNode;
Expand Down
Loading