BufferAttribute setVector & setColor convenience methods#33348
Open
Kodub wants to merge 3 commits intomrdoob:devfrom
Open
BufferAttribute setVector & setColor convenience methods#33348Kodub wants to merge 3 commits intomrdoob:devfrom
Kodub wants to merge 3 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
231773f to
ba530c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new convenience methods to
BufferAttribute&InterleavedBufferAttribute.setVector2()setVector3()setVector4()setColor()These helps simplify setting vectors and colors which seem to be a quite common pattern as most instances of
setXYZare possible to change into these new convenience methods.Before:
After:
Advantages
attribute.setXYZ(0, v.x, v.x, v.z);Discussion points
setXYZFromVector3andsetXYZFromColorRGB. Would these names be preferred to make it clearer that these are convenience methods forsetXYZ?setXYZmethods. The extra function call might introduce a small performance overhead.