WebGLRenderer Shaders: introduce transformNormalByInverseViewMatrix()#33351
Open
WestLangley wants to merge 2 commits intomrdoob:devfrom
Open
WebGLRenderer Shaders: introduce transformNormalByInverseViewMatrix()#33351WestLangley wants to merge 2 commits intomrdoob:devfrom
transformNormalByInverseViewMatrix()#33351WestLangley wants to merge 2 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
WestLangley
commented
Apr 7, 2026
| reflectVec = normalize( mix( reflectVec, normal, pow4( roughness ) ) ); | ||
|
|
||
| reflectVec = inverseTransformDirection( reflectVec, viewMatrix ); | ||
| reflectVec = transformNormalByInverseViewMatrix( reflectVec, viewMatrix ); |
Collaborator
Author
There was a problem hiding this comment.
Hmm... reflectVec. What to make of applying this method to this particular vector?
Collaborator
Author
There was a problem hiding this comment.
Maybe we add transformDirectionByInverseViewMatrix() for clarity? The code would be the same. It would be a small duplication of code, but more clear.
WestLangley
changed the title
transformNormalByInverseViewMatrix()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
inverseTransformDirection()and introduces two new functions:transformNormalByInverseViewMatrix()andtransformDirectionByInverseViewMatrix().inverseTransformDirection()was used to transform both normals and direction vectors, leading to confusion.