Skip to content

Updated react version. Added babel #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirillsbarsukov wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

Updated react version. Added babel #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions modules/pdb_react/components/react_example_1/react-example-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
ReactDOM.render(React.createElement(
'h1',
null,
'Hello, world!'
), document.getElementById('react-example-1'));
// The code was taken from https://reactjs.org/docs/components-and-props.html
function Welcome(props) {
return <h1>Hello, {props.name}</h1>;
}

const element = <Welcome name="Sara" />;

ReactDOM.render(
element,
document.getElementById('root')
);
3 changes: 2 additions & 1 deletion modules/pdb_react/components/react_example_1/react_example_1.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ module_status: active
presentation: react
add_js:
footer:
'react-example-1.js': {}
'react-example-1.js': { preprocess: 0, attributes: { type: text/babel } }

5 changes: 3 additions & 2 deletions modules/pdb_react/pdb_react.libraries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
react:
version: VERSION
js:
//cdnjs.cloudflare.com/ajax/libs/react/15.0.1/react.min.js: {type: external, minified: true}
//cdnjs.cloudflare.com/ajax/libs/react/15.0.1/react-dom.min.js: {type: external, minified: true}
//unpkg.com/react@16/umd/react.production.min.js: {type: external, minified: true}
//unpkg.com/react-dom@16/umd/react-dom.production.min.js: {type: external, minified: true}
//unpkg.com/@babel/standalone/babel.min.js: {type: external, minified: true}
dependencies:
- core/drupal
- core/drupalSettings