arm64: dts: qcom: msm8916-vivo-pd1505f: Add initial device tree and Panel#442
arm64: dts: qcom: msm8916-vivo-pd1505f: Add initial device tree and Panel#442QuiXan wants to merge 9 commits intomsm8916-mainline:wip/msm8916/7.0from
Conversation
|
For me, fixing these problems is too difficult. If possible, please directly help me correct them. These work fine on my device. Oh right, the kernel needs to enable the smb3xx driver in order to ensure the battery and charging work properly. |
QuiXan
changed the title
TravMurav
left a comment
TravMurav
left a comment
There was a problem hiding this comment.
Thanks for the submission! Please see some comments below.
On top of this, I have to mention that due to maintenance load we don't accept DTS submissions that aren't (partially) sent upstream. Almost everything you've added should be possible to submit and get accepted in mainline Linux (i.e. Torvalds's tree), with an exception of the device panel driver (and corresponding DTS nodes additions) and, if you rely on that, non-upstreamed charger drivers.
I'd expect this submission to have four commits:
- Document DT bindings for your device;
- Add your device dts;
- Update your dts to add display panel
- (optionally) !squash commit generated by l-p-d with the panel driver that you need.
Then the first two commits can be sent to LKML and backported to this tree.
For examples on how submissions to LKML are prepared and handled, you can refer to recent examples:
- https://lore.kernel.org/linux-arm-msm/20260311-wiko-chuppito-v5-0-0a8656cca1b3@posteo.de/
- https://lore.kernel.org/linux-arm-msm/20260414184429.168612-1-linmengbo06890@proton.me/
You can read the reviews left upstream on previous versions of those patchsets to see how review on LKML goes and maybe see some information relevant to you.
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&ts_int_default &ts_rst_default>; |
There was a problem hiding this comment.
| pinctrl-names = "default"; | |
| pinctrl-0 = <&ts_int_default &ts_rst_default>; | |
| pinctrl-0 = <&ts_int_default>, <&ts_rst_default>; | |
| pinctrl-names = "default"; |
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&lcd_bl_en_default>; |
There was a problem hiding this comment.
-names always last
| pinctrl-names = "default"; | |
| pinctrl-0 = <&lcd_bl_en_default>; | |
| pinctrl-0 = <&lcd_bl_en_default>; | |
| pinctrl-names = "default"; |
| interrupt-parent = <&tlmm>; | ||
| interrupts = <13 IRQ_TYPE_EDGE_FALLING>; |
There was a problem hiding this comment.
please always interrupts-extended
| pm8916_l17: l17 { | ||
| regulator-min-microvolt = <2850000>; | ||
| regulator-max-microvolt = <2850000>; | ||
| }; | ||
| pm8916_l16: l16 { | ||
| regulator-min-microvolt = <2850000>; | ||
| regulator-max-microvolt = <2850000>; | ||
| }; |
| pm8916_l2: l2 { | ||
| regulator-min-microvolt = <1200000>; | ||
| regulator-max-microvolt = <1200000>; | ||
| regulator-always-on; /* 可能需要保持常开 */ |
There was a problem hiding this comment.
I don't understand the comment here...
This regulator is part of reference design and is already enabled in the dtsi you include.
| vdd-supply = <&pm8916_l2>; | ||
| vddcx-supply = <&rpmpd MSM8916_VDDCX>; |
There was a problem hiding this comment.
do you actually need this? I don't think this is correct
| @@ -0,0 +1,421 @@ | |||
| // SPDX-License-Identifier: GPL-2.0-only | |||
There was a problem hiding this comment.
Please limit this to only the panel you can verify working on a real device, and make a submission to https://github.com/msm8916-mainline/linux-panel-drivers.
You can include the commit that was generated by linux-panel-drivers generate.sh script, please keep that commit exactly as it was generated then.
2 participants
No description provided.