Skip to content

handle interactions w/ explosions#3

Merged
Niklp09 merged 7 commits into
masterfrom
boom
Oct 3, 2023
Merged

handle interactions w/ explosions#3
Niklp09 merged 7 commits into
masterfrom
boom

Conversation

@fluxionary

@fluxionary fluxionary commented Jul 28, 2023

Copy link
Copy Markdown
Member

this was originally pyrollo#50

  1. sign entities shouldn't be destroyed by explosions if the sign isn't destroyed
  2. sign entities (and node metadata) should be removed if the sign is destroyed by an explosion.

wsor4035
wsor4035 reviewed Jul 29, 2023
View reviewed changes

@wsor4035 wsor4035 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial thoughts

Comment thread display_api/display.lua Outdated
Comment thread display_api/display.lua Outdated
@fluxionary

fluxionary commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

i'll get back to this at some point, it's on the todo list

@Niklp09

Niklp09 commented Sep 13, 2023

Copy link
Copy Markdown
Member

@fluxionary Can we merge this?

@Niklp09
Niklp09 requested a review from wsor4035 October 2, 2023 15:45
@Niklp09
Niklp09 merged commit 2c1efed into master Oct 3, 2023
@Niklp09
Niklp09 deleted the boom branch October 3, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes
@wsor4035 wsor4035 Awaiting requested review from wsor4035

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fluxionary @Niklp09 @wsor4035 @BuckarooBanzay