Feat: Add a password generator button in Add Key#69
Merged
mulbc merged 2 commits intomulbc:masterfrom Mar 23, 2026
Merged
Conversation
mulbc
approved these changes
Mar 23, 2026
Owner
mulbc
left a comment
mulbc
left a comment
There was a problem hiding this comment.
lgtm - thanks for adding this!
I will merge this today and see if I enhance it before bundling up a new version
Author
|
hey @mulbc |
Owner
|
damn... it's been a month already? I will push it right today |
mulbc
pushed a commit
that referenced
this pull request
Apr 27, 2026
* add-key: added password generator * formatted with prettier --------- Co-authored-by: Raph@PC42 <raphael@42factory.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a button to generate a 20 char length password directly from the Add Key window.
The charset is Fort knox (
abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@#$%^&*()_+~|}{[]:;?><,./-=`)By clicking on Generate, the password input is being filled with the generated password and it is being copied to the clipboard.
I had to move the function copyStringToClipboard() from popup.js to common.js so the code can be reused in addKey.js.
In the future it could be nice to add a way to customize the password generation in a tiny menu, like setting the desired password length, character range, etc.