WAN-97: tighten self-host startup readiness#4315
Draft
haoxianhan wants to merge 3 commits into
Draft
Conversation
|
@haoxianhan is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BACKEND_PORT, keepingAPI_PORT/SERVER_PORT/PORTonly as compatibility aliases.start.shserver-stack startup by default, waits on backend/readyzplus frontend/, fails fast with targeted diagnostics, and makes source daemon startup explicit opt-in viaSELFHOST_START_DAEMON=true.Review notes
25c039625(my script) that addedstart.sh/stop.sh; the WAN-97 cleanup commit is549ac5487.Verification
bash scripts/selfhost-config.test.shbash -n start.sh scripts/selfhost-env.sh scripts/local-env.sh scripts/install.sh scripts/selfhost-config.test.shgit diff --checkdocker compose --env-file .env.example -f docker-compose.selfhost.yml configBACKEND_PORT=9100 FRONTEND_PORT=3100 docker compose --env-file .env.example -f docker-compose.selfhost.yml configmake -n selfhost-waitBACKEND_PORT=9100 FRONTEND_PORT=3100 make -n selfhost-waitBIND_HOST=192.168.1.100 BACKEND_PORT=9100 FRONTEND_PORT=3100 make -n selfhost-waitgo test ./cmd/multica -run 'TestResolveSelfHostServerURL|TestSelfHostAppURLHonorsEnv|TestPersistSelfHostConfigIfReachable'