fix(desktop): avoid duplicate sidebar tabs#4353
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
|
@beastpu is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
431dff6 to
31ddc36
Compare
Contributor
Author
|
Updated this PR after rebasing onto latest Fresh local validation after the rebase:
CI has started on the rebased commit |
Contributor
Author
|
Status update: rebased PR is now green and mergeable. GitHub CI passed ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SortablePinItem.SidebarMenuButton.renderelement and assert the activation flag.Refs #4284
Related to #4326
Verification
pnpm --filter @multica/views exec vitest run layout/app-sidebar.test.tsx navigation/app-link.test.tsxpnpm --filter @multica/views typecheckpnpm --filter @multica/views lint(exits 0; existing warnings only)git diff --check upstream/main...HEAD