Skip to content

fix(desktop): avoid duplicate sidebar tabs#4353

Open
YOMXXX wants to merge 1 commit into
multica-ai:mainfrom
YOMXXX:codex/fix-4284-pinned-tabs
Open

fix(desktop): avoid duplicate sidebar tabs#4353
YOMXXX wants to merge 1 commit into
multica-ai:mainfrom
YOMXXX:codex/fix-4284-pinned-tabs

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Route desktop sidebar primary nav links through tab open-or-activate behavior so existing issue/project paths are activated instead of duplicated.
  • Apply the same activation path to pinned sidebar issue/project rows via SortablePinItem.
  • Strengthen sidebar/app-link regression coverage so pinned links render the mocked SidebarMenuButton.render element and assert the activation flag.

Refs #4284
Related to #4326

Verification

  • pnpm --filter @multica/views exec vitest run layout/app-sidebar.test.tsx navigation/app-link.test.tsx
  • pnpm --filter @multica/views typecheck
  • pnpm --filter @multica/views lint (exits 0; existing warnings only)
  • git diff --check upstream/main...HEAD

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

@beastpu is attempting to deploy a commit to the IndexLabs Team on Vercel.

A member of the Team first needs to authorize it.

@YOMXXX YOMXXX force-pushed the codex/fix-4284-pinned-tabs branch from 431dff6 to 31ddc36 Compare June 20, 2026 04:25
@YOMXXX

YOMXXX commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Updated this PR after rebasing onto latest main; the merge conflict from the sidebar test changes is resolved.

Fresh local validation after the rebase:

  • pnpm --filter @multica/views exec vitest run layout/app-sidebar.test.tsx navigation/app-link.test.tsx — 13 tests passed
  • pnpm --filter @multica/views typecheck
  • pnpm --filter @multica/views lint — exits 0, existing warnings only
  • git diff --check upstream/main...HEAD

CI has started on the rebased commit 31ddc36a5.

@YOMXXX

YOMXXX commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Status update: rebased PR is now green and mergeable. GitHub CI passed (frontend, backend, and both installer jobs), and mergeStateStatus=CLEAN. I attempted auto-merge, but GitHub returned YOMXXX does not have the correct permissions to execute MergePullRequest, so a maintainer needs to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants