mptcp: validate MPTcpExtInvalidOptionRx on MP_CAPABLE fallback paths - #205
Draft
Dwyane-Yan wants to merge 1 commit into
Draft
mptcp: validate MPTcpExtInvalidOptionRx on MP_CAPABLE fallback paths#205Dwyane-Yan wants to merge 1 commit into
Dwyane-Yan wants to merge 1 commit into
Conversation
The mptcp_net-next kernel now increments the MPTcpExtInvalidOptionRx MIB counter whenever the MPTCP option parser ignores an option due to a wrong version, disallowed flags, bad length, etc. These four packetdrill tests already inject malformed MP_CAPABLE options that are rejected by the parser, causing a TCP fallback: - v1_bind_tcpfallback_wrongver: v0 SYN (version < v1) - v1_connect_tcpfallback_wrongver: v0 SYN-ACK (version != v1) - v1_bind_tcpfallback_flagB: extensibility flag set - v1_bind_tcpfallback_flagH: HMAC-SHA256 flag missing Extend their nstat validation to also check that MPTcpExtInvalidOptionRx has been incremented. The connect-side wrong-version test had no nstat section, so add the `nstat -n` initialization along with the new assertion. Assisted-by: Claude: GLM-5.2 Signed-off-by: Gang Yan <yangang@kylinos.cn>
Member
|
Thank you for this PR. Indeed, all of them should not have the MIB counter increased. Maybe we could keep this PR but check that the counter is 0 as expected? We could also have another test sending invalid options, e.g. 2 different DSS (if packetdrill allows that in the current implementation) or an MPC + a DSS, etc. Note that on my side, I called the counter |
Author
|
Sounds good, I can do this after your patches are sent to the mail list. Thanks |
Member
|
Thanks! Reopening and converting to a draft, just not to forget about it. |
matttbe
marked this pull request as draft
August 14, 2026 22:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mptcp_net-next kernel now increments the MPTcpExtInvalidOptionRx MIB counter whenever the MPTCP option parser ignores an option due to a wrong version, disallowed flags, bad length, etc.
These four packetdrill tests already inject malformed MP_CAPABLE options that are rejected by the parser, causing a TCP fallback:
Extend their nstat validation to also check that MPTcpExtInvalidOptionRx has been incremented. The connect-side wrong-version test had no nstat section, so add the
nstat -ninitialization along with the new assertion.Assisted-by: Claude: GLM-5.2