Skip to content

fix(spotify_connect): reload provider on broken pipe errors #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
prydie wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(spotify_connect): reload provider on broken pipe errors #2997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions music_assistant/providers/spotify_connect/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,19 @@ def _process_librespot_stderr_line(self, line: str) -> None:
and "Using StdoutSink (pipe) with format: S16" in line
):
self._librespot_started.set()

# Librespot catches "Broken pipe" errors (os error 32) and transitions to
# Paused state without exiting. We must forcibly close it to trigger restart.
if "Broken pipe (os error 32)" in line:
self.logger.debug("[%s] %s", self.name, line)
self.logger.error(
"Librespot output pipe is broken (Zombie State). Restarting process..."
)
if self._librespot_proc:
# self._librespot_proc.close() is too polite; we don't end up restarting.
self.mass.create_task(self.mass.load_provider_config(self.config))
return

if "error sending packet Os" in line:
return
if "dropping truncated packet" in line:
Expand Down
Loading