Conversation
|
Since we are trying to lookup on musicbrainz it is important clean artist and tracks names are sent. New functions added to support this. |
|
Also I know some comments need to be tidied up or removed just wanted to keep my thought patterns there for now. |
|
I think we should always prefer the track metadata over anything else.
Also, I don't particular like the fact that this PR is duplicating logic, reinventing the wheel. Better improve existing logic instead of creating sidepaths that do more or less the same. Then finally, we should aim at improving the lookup and metadata retrieval methods in the musicbrainz controller in a dedicated PR, not mangled into a PR that wants to fetch metadata for a radio stream. Note that we can actually fetch images from MusicBrainz too using the coverart archive. |
This is not possible with MB or the Cover Art Archive as the endpoints are at the release level not recording. https://community.metabrainz.org/t/how-to-get-search-cover-image-of-track/337917/3 There is equally no way to query a track at TheAudioDB or Fanart.tv. MA, of course, does store images at track level and that is already the first thing I look for. So your priortiy order is already how it works except for the single image as the second option so I have added that. I have also created a PR just with the musicbrainz changes and marked this as draft until that is merged. |
|
I appreciate it's an outlier, but just checking if there is a way to 'opt-out' of this feature when this functionality is already present in a provider as it is in the BBC Sounds one? |
|
Since we made that change with the callback it should be fine I think? |
|
Ah, I didn't even make the connection somehow! Strangely, one Sounds endpoint is missing track images, so I might well look at using these helpers as well, once it's landed. |
4c15b8a to
c990c43
Compare
3af3d1d to
d06751d
Compare
Looks up artist/track artwork for radio streams using ICY and HLS metadata. Uses MusicBrainz to find release groups, then queries fanart.tv and TheAudioDB for artwork. Prefers single artwork first, falls back to album, then artist. Includes artist name normalization for radio metadata (handles "Last, First" format, business suffixes, known band names), swap detection for stations that send "Track - Artist" format, and "The " prefix handling for searches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
f16f141 to
d1e8c62
Compare
With all the UI improvements I thought it would be good to enhance radio stations to rather than just show the station logo but instead show the current single cover/album/artist. This PR allows for the display of thumbnail images for radio streams when track metadata (Artist - Title) is available.
How it works:
Release group matching: Aggregates release groups from all matching MusicBrainz recordings and sorts by release date. Singles are tried first (for exact track artwork), then albums. Compilations and live albums are filtered out.
Title cleaning: Strips version suffixes (remastered, live, etc.) and featuring credits from track names to improve MusicBrainz matching.
Edge cases handled: