Add AccessHandler to handler file permissions#1319
Add AccessHandler to handler file permissions#1319amjadjibon wants to merge 1 commit intomvdan:masterfrom
AccessHandler to handler file permissions#1319Conversation
mvdan
left a comment
There was a problem hiding this comment.
The fallback logic doesn't seem right. As the TODO says, we need this logic to unconditionally use a handler, rather than use a mix of the real OS and a handler. If we mix both, then the sandboxing is entirely pointless still.
Hi, I'm looking at your feedback about the access handler fallback logic mixing real OS calls with handler calls. I'm wondering if adding a new Or would you prefer a different direction? The TODO mentions v4, so I want to make sure I'm heading in the right direction before proceeding. Thanks! |
18d6e68 to
dfe0444
Compare
…ssion checks from the Runner
dfe0444 to
6354465
Compare
AccessHandler to handler file permissions
#1318