Fix acquisition ZIP integrity checks#106
Open
besendorf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes cases where AndroidQF could finish secure storage after producing an invalid or incomplete ZIP archive.
The root cause was that finalization errors from
archive/zipand the underlying files were not checked, so failures while writing the ZIP central directory could be missed. The archive writer now closes, syncs, and verifies the ZIP before reporting success.The change also writes encrypted output through a temporary file before renaming it into place, avoids appending to existing encrypted output, and skips the destination archive if it is inside the source directory.