Fix trusted APK removal#109
Open
besendorf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108.
This updates package APK certificate handling so both the disk-backed and streaming paths use the same trusted APK decision logic.
The root cause was that trusted-certificate handling lived inline in separate code paths. This made the removal behavior harder to reason about and left the disk path dependent on a nested verification branch. The shared helper now records certificate metadata consistently, preserves APKs when certificate verification fails, and removes/skips APKs only when the signature verifies and the verified signing certificate is in the trusted list.
For users, selecting trusted APK removal should now consistently limit output size without dropping APKs whose signatures could not be verified.