Jameson/CT-1374 - #147
Merged
Merged
Conversation
Jameson13B
requested review from
ash-wright123,
codingLogan,
mwclemy and
wesrisenmay-mx
as code owners
May 27, 2025 19:39
Jameson13B
force-pushed
the
jameson/CT-1374
branch
from
May 27, 2025 19:48
55646e1 to
7be7a82
Compare
Collaborator
|
It tests well for me, but if there is no DDA accounts does it make sense for the try again to just keep trying to run the job? Or maybe this is not the correct view? It just seems like I get stuck on this page. |
Collaborator
|
Okay after testing with cypress the above is not what the screen is supposed to look like the error I got must be different. However the iavNonDDA cypress test is failing so that will need to be fixed on the MX connect side. |
ash-wright123
previously approved these changes
May 30, 2025
Jameson13B
force-pushed
the
jameson/CT-1374
branch
from
June 10, 2025 21:27
a30d7f7 to
e0db371
Compare
Jameson13B
force-pushed
the
jameson/CT-1374
branch
from
June 23, 2025 14:25
e0db371 to
d1b51ff
Compare
Jameson13B
force-pushed
the
jameson/CT-1374
branch
from
July 10, 2025 22:00
a919c2a to
78414ea
Compare
… message ActionableError used to read member.most_recent_job_detail_code. We now read member.error which includes the code, user message, etc. The user message also comes back translated based off the "Accept-Language" header when hitting the GET member(s) endpoints. BREAKING CHANGE: ActionableError is reading an new field from the API. Consumers will need to update their API to provide this new field before updating.
Jameson13B
force-pushed
the
jameson/CT-1374
branch
from
July 14, 2025 16:08
78414ea to
b07b9cf
Compare
mwclemy
approved these changes
Jul 15, 2025
mwclemy
left a comment
mwclemy
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I couldn't run E2E since Sand is having issues.
Let's see how things go in QA.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mxcom.atlassian.net/browse/CT-1374
Changes
GETmember endpoint, we now pass the client locale. This allowsuser_messagereturned for errors to be translated correctly.ActionableErrornow uses themember.errorobject to determine an error instead ofmember.most_recent_job_detail_code.ActionableErrornow uses the the translateduser_messagefrom theerrorobject instead of local string.Testing instructions
ActionableErrorview renders.ActionableErrorview renders.es.ActionableErrorview renders and all text is translated to Spanish.