Switch from @kyper/mui to @mxenabled/mxui - #182
Conversation
|
This is a pretty big change, in terms of how many files and components could be affected. I'll take some time to load this up, run e2e tests, and manually run some other views and tests. |
Based on the conversation with the MXUI team, this migration may affect client theme overrides. I'm holding off on the review for now to make sure those overrides are properly accounted for first. |
|
Pulling this down now to start testing. |
|
Given the above uncaught issues, we may need to revisit the approach to migrating to MUI/MXUI... I recommend that we slow the migration down. Ideally, we need to make sure we migrate correctly with one flow or set of pages at a time. With 77 files changed, there's no way to actually know what issues we're going to run into unless we manually test every view we have. It's a hard pill to swallow for the author and reviewer when there are so many changes 😢 , and it's especially painful when revisions are needed to fix any found issues. Now, we don't have to break it up, but it would make it easier and more accurate for everyone if we do, especially if we're trying to be accurate to Figma's designs. |
I’m not opposed to breaking up the PR if needed, but I think in this case most of the changes are simply import updates (mainly Text, some icons, and a few MUI overrides that are specific to our project). The only notable issue I’ve run into so far is the misaligned logos on the verification account list that Ashley caught, which turned out to be related to Given that, I see this migration as fairly low risk. It’s been stalled for a while already as we’ve tried to ensure everything works correctly, and at this point it’s starting to block both our work and UCW’s. My sense is that keeping it as a single PR will help us move forward faster while still being manageable to review, since the bulk of changes are straightforward. |
|
The misaligned styles have been fixed. It’s ready for another look whenever someone has a chance. @ash-wright123 |
Jameson13B
left a comment
There was a problem hiding this comment.
Massive MR but in my flows and tests things seem to be working great. Awesome job getting Kyper out.
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |




Since
@kyper/muiis no longer maintained, this change updates imports to@mxenabled/mxui, which enables us to use newly added components going forward. Everything should continue to work as expected.Changes
@kyper/muiimports with@mxenabled/mxuiTesting Instructions