Skip to content

Switch from @kyper/mui to @mxenabled/mxui - #182

Merged
mwclemy merged 11 commits into
masterfrom
cmwimo/migrate-to-mxui
Sep 11, 2025
Merged

Switch from @kyper/mui to @mxenabled/mxui #182
mwclemy merged 11 commits into
masterfrom
cmwimo/migrate-to-mxui

Conversation

@mwclemy

@mwclemy mwclemy commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Since @kyper/mui is no longer maintained, this change updates imports to @mxenabled/mxui, which enables us to use newly added components going forward. Everything should continue to work as expected.

Changes

  • Replaced @kyper/mui imports with @mxenabled/mxui
  • Applied MXUI theming override pattern by passing a single primary color and letting MXUI generate the rest of the palette

Testing Instructions

  • Go through all Connect flows and confirm everything still appears the same
  • Run integrations and E2E tests

@mwclemy mwclemy changed the title Migrate from @kyper/mui to @mxenabled/mxui Suitch from @kyper/mui to @mxenabled/mxui Aug 4, 2025
@mwclemy mwclemy changed the title Suitch from @kyper/mui to @mxenabled/mxui Switch from @kyper/mui to @mxenabled/mxui Aug 4, 2025
@mwclemy mwclemy added the Needs Review This item needs review label Aug 5, 2025
@mwclemy mwclemy mentioned this pull request Aug 5, 2025
@codingLogan

Copy link
Copy Markdown
Collaborator

This is a pretty big change, in terms of how many files and components could be affected.

I'll take some time to load this up, run e2e tests, and manually run some other views and tests.

@mwclemy mwclemy removed the Needs Review This item needs review label Aug 7, 2025
@mwclemy

mwclemy commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

This is a pretty big change, in terms of how many files and components could be affected.

I'll take some time to load this up, run e2e tests, and manually run some other views and tests.

Based on the conversation with the MXUI team, this migration may affect client theme overrides. I'm holding off on the review for now to make sure those overrides are properly accounted for first.

@mwclemy mwclemy changed the title Switch from @kyper/mui to @mxenabled/mxui DRAFT | Switch from @kyper/mui to @mxenabled/mxui Aug 7, 2025
@mwclemy mwclemy changed the title DRAFT | Switch from @kyper/mui to @mxenabled/mxui Switch from @kyper/mui to @mxenabled/mxui Sep 8, 2025
@mwclemy mwclemy self-assigned this Sep 8, 2025
@mwclemy mwclemy added the Needs Review This item needs review label Sep 8, 2025
@ash-wright123

Copy link
Copy Markdown
Collaborator

Pulling this down now to start testing.

@ash-wright123

Copy link
Copy Markdown
Collaborator
Screenshot 2025-09-08 at 11 39 54 AM

The logos on the verification account list are off.

@ash-wright123

Copy link
Copy Markdown
Collaborator
Screenshot 2025-09-08 at 11 38 40 AM

The bottom line on the favorites screen is a bit too high and cutting into the list.

@ash-wright123

Copy link
Copy Markdown
Collaborator
Screenshot 2025-09-08 at 11 36 38 AM

The asterisk for the required field is on a new line now on the delete member survey and it should be on the same line as the description.

@ash-wright123

Copy link
Copy Markdown
Collaborator
Screenshot 2025-09-08 at 11 32 37 AM

In the entire disclosure the arrows are off not just on this screen but in the subsequent screens as well.

@codingLogan

Copy link
Copy Markdown
Collaborator

Given the above uncaught issues, we may need to revisit the approach to migrating to MUI/MXUI...

I recommend that we slow the migration down. Ideally, we need to make sure we migrate correctly with one flow or set of pages at a time. With 77 files changed, there's no way to actually know what issues we're going to run into unless we manually test every view we have.

It's a hard pill to swallow for the author and reviewer when there are so many changes 😢 , and it's especially painful when revisions are needed to fix any found issues.

Now, we don't have to break it up, but it would make it easier and more accurate for everyone if we do, especially if we're trying to be accurate to Figma's designs.

@mwclemy

mwclemy commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator Author

Given the above uncaught issues, we may need to revisit the approach to migrating to MUI/MXUI...

I recommend that we slow the migration down. Ideally, we need to make sure we migrate correctly with one flow or set of pages at a time. With 77 files changed, there's no way to actually know what issues we're going to run into unless we manually test every view we have.

It's a hard pill to swallow for the author and reviewer when there are so many changes 😢 , and it's especially painful when revisions are needed to fix any found issues.

Now, we don't have to break it up, but it would make it easier and more accurate for everyone if we do, especially if we're trying to be accurate to Figma's designs.

I’m not opposed to breaking up the PR if needed, but I think in this case most of the changes are simply import updates (mainly Text, some icons, and a few MUI overrides that are specific to our project). The only notable issue I’ve run into so far is the misaligned logos on the verification account list that Ashley caught, which turned out to be related to CssBaseline introducing margin conflicts with older Kyper styles.

Given that, I see this migration as fairly low risk. It’s been stalled for a while already as we’ve tried to ensure everything works correctly, and at this point it’s starting to block both our work and UCW’s. My sense is that keeping it as a single PR will help us move forward faster while still being manageable to review, since the bulk of changes are straightforward.

@mwclemy

mwclemy commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator Author

The misaligned styles have been fixed. It’s ready for another look whenever someone has a chance. @ash-wright123

@Jameson13B Jameson13B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive MR but in my flows and tests things seem to be working great. Awesome job getting Kyper out.

@mwclemy
mwclemy merged commit 418a5ee into master Sep 11, 2025
5 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mwclemy
mwclemy deleted the cmwimo/migrate-to-mxui branch September 11, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review This item needs review released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants