Skip to content

Using SelectionBox component from MXUI - #184

Merged
mwclemy merged 6 commits into
masterfrom
cmwimo/CT-1615
Aug 12, 2025
Merged

Using SelectionBox component from MXUI#184
mwclemy merged 6 commits into
masterfrom
cmwimo/CT-1615

Conversation

@mwclemy

@mwclemy mwclemy commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

This MR replaces the Kyper SelectionBox with the MXUI version to address the CT-1615 bug.

This is a screenshot showing how the SelectionBox appears:

Screenshot 2025-08-07 at 13 06 25

This is a screenshot showing how long text appears in the SelectionBox:

Screenshot 2025-08-07 at 13 30 35

Testing instructions

  • Load connect in verification and connect to gringotts in Sand
  • You should see account selection screen
  • Make sure the selection box on that screen looks as expected.
  • Run all the integrations and E2E tests

@mwclemy mwclemy added the Needs Review This item needs review label Aug 5, 2025
@mwclemy
mwclemy changed the base branch from cmwimo/migrate-to-mxui to master August 7, 2025 18:51
Comment thread src/views/manualAccount/ManualAccountForm.tsx Outdated
Comment thread src/views/manualAccount/ManualAccountForm.tsx Outdated
Comment thread src/views/microdeposits/AccountInfo.js Outdated
@codingLogan

codingLogan commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

This is looking good overall. One last concern, lets make sure that the analytics are not recording these elements. @mwclemy could you post a screenshot of the input still being secure?

@mwclemy

mwclemy commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator Author

This is looking good overall. One last concern, lets make sure that the analytics are not recording these elements. @mwclemy could you post a screenshot of the input still being secure?

Here are the screenshots of the inputs, including the new SelectionBox component:

Screenshot 2025-08-11 at 11 48 10 Screenshot 2025-08-11 at 11 50 08

Comment thread src/privacy/withProtection.tsx
@codingLogan

Copy link
Copy Markdown
Collaborator

The Connections e2e test is currently failing internally. We'll need to resolve those before we move these changes forward.

@mwclemy

mwclemy commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator Author

The Connections e2e test is currently failing internally. We'll need to resolve those before we move these changes forward.

I made a few small tweaks to how we select the Manual Account Personal and Business checkboxes in the MXConnect Cypress tests, since MUI was adding opacity: 0, which Cypress considers not visible. The tests should pass when you check out my MXConnect branch: cmwimo/CT-1615.

Screenshot 2025-08-11 at 18 54 26

@mwclemy
mwclemy merged commit c58e14f into master Aug 12, 2025
3 checks passed
@mwclemy
mwclemy deleted the cmwimo/CT-1615 branch August 12, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review This item needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants