Using SelectionBox component from MXUI - #184
Merged
Merged
Conversation
mwclemy
requested review from
Jameson13B,
ash-wright123,
codingLogan and
wesrisenmay-mx
as code owners
August 4, 2025 22:58
codingLogan
reviewed
Aug 7, 2025
codingLogan
reviewed
Aug 7, 2025
codingLogan
reviewed
Aug 7, 2025
Collaborator
|
This is looking good overall. One last concern, lets make sure that the analytics are not recording these elements. @mwclemy could you post a screenshot of the input still being secure? |
Collaborator
Author
Here are the screenshots of the inputs, including the new SelectionBox component:
|
codingLogan
reviewed
Aug 11, 2025
Collaborator
|
The Connections e2e test is currently failing internally. We'll need to resolve those before we move these changes forward. |
Collaborator
Author
codingLogan
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This MR replaces the Kyper
SelectionBoxwith the MXUI version to address the CT-1615 bug.This is a screenshot showing how the SelectionBox appears:
This is a screenshot showing how long text appears in the SelectionBox:
Testing instructions