Skip to content

Jameson/CT-1659 - #185

Merged
Jameson13B merged 13 commits into
masterfrom
jameson/CT-1659
Aug 26, 2025
Merged

Jameson/CT-1659#185
Jameson13B merged 13 commits into
masterfrom
jameson/CT-1659

Conversation

@Jameson13B

@Jameson13B Jameson13B commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

https://mxcom.atlassian.net/browse/CT-1659

Changes

  • Added new InstitutionDisabled view/step that renders when institution.is_disabled_by_client is true.

Testing instructions

*You will need to block an institution for your test client in Batcave.

  • Load a member that is connected to an institution with is_disabled_by_client.
    • Ensure the new view renders and functions as expected.
  • Load Connect with an institution guid/code with is_disabled_by_client.
    • Ensure the new view renders and functions as expected.
  • Run all tests available.

@Jameson13B Jameson13B self-assigned this Aug 5, 2025
@Jameson13B Jameson13B added the Needs Review This item needs review label Aug 5, 2025
@mwclemy

mwclemy commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

This doesn’t seem fully ready for testing yet. The institution search request is the only one returning the is_disabled_by_client flag as true. When selecting an institution that should have the flag set to true, it flips to false for some reason. I’d assume the endpoints that request a specific institution by guid aren’t populating the flag correctly yet.

@mwclemy

mwclemy commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

One thing I noticed: When you click on an already connected institution with the is_disabled_by_client flag set to true from the list of existing connections in verification, it throws this error:

Screenshot 2025-08-21 at 18 01 34

I wonder if this will be resolved once the flag is populated on the member and we’re redirecting the user to the InstitutionDisabled screen when the flag is true, but I wanted to flag it as something we’ll need to make sure works correctly.

@Jameson13B
Jameson13B changed the base branch from master to jameson/CT-1658 August 25, 2025 18:28
@Jameson13B
Jameson13B changed the base branch from jameson/CT-1658 to master August 25, 2025 18:28
@codingLogan

Copy link
Copy Markdown
Collaborator

In my companion MR for the Connections widget, I added some hard-coded values that should limit this new blocked experience to the specific Chase Bank members that we're concerned about. While it is gross... this will make it less likely to disrupt more users than we intend to, like what happened to Regions recently... They block themselves, and their existing members might be impacted with a message they shouldn't need to see 😓 .

https://gitlab.com/mxtechnologies/mx/connect-widget/-/blob/7dcc8bd37089841c8efeb24b8d8292f4e3a41a40/src/connections/institutionBlocks/institutionBlocks.ts

In the near future we'll need to make this more dynamic so the backend provides us a message and a list of what institutions are blocked. Once we have that fully fleshed out, we can take out the hard-coding guid and name. (I'm not sure when this will be, or if it is even being discussed, but this means we're limited to only being worried about Chase Bank for existing members)

codingLogan
codingLogan previously approved these changes Aug 26, 2025
emilysallstrom
emilysallstrom previously approved these changes Aug 26, 2025

@emilysallstrom emilysallstrom left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Jameson13B
Jameson13B dismissed stale reviews from emilysallstrom and codingLogan via 055e4d8 August 26, 2025 15:09
@Jameson13B
Jameson13B merged commit ac3c4a4 into master Aug 26, 2025
3 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review This item needs review released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants