Skip to content

fix: adding new fields to destination accounts - #319

Merged
kcpotluri merged 1 commit into
masterfrom
nd/add_destination_fields
Jul 25, 2025
Merged

fix: adding new fields to destination accounts#319
kcpotluri merged 1 commit into
masterfrom
nd/add_destination_fields

Conversation

@ndasari2

@ndasari2 ndasari2 commented Jul 24, 2025

Copy link
Copy Markdown

Summary of Changes

Adding new fields in the destination endpoint to support cross account transfer calls

SPECS changes MR
https://gitlab.com/mxtechnologies/mx/gutenberg/-/merge_requests/901

Fixes # (issue)

Public API Additions/Changes

Adding new fields in the destination endpoint to support cross account transfer calls payload

Downstream Consumer Impact

This should not impact any existing code bases or client as this is backward compatiable

How Has This Been Tested?

Nothing to test much here as this is just adding a new field in the destination payload

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@meotch

meotch commented Jul 24, 2025

Copy link
Copy Markdown

Should account_type_subtype be account_subtype instead? type_subtype is redundant

@kcpotluri

kcpotluri commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Should account_type_subtype be account_subtype instead? type_subtype is redundant

No this is similar to account_type_ number but rather than number we added a new fields to be used as string. So Joe suggested to keep it account_type_subtype for easy differentiation

@kcpotluri
kcpotluri merged commit a281ced into master Jul 25, 2025
3 of 4 checks passed
@kcpotluri
kcpotluri deleted the nd/add_destination_fields branch July 25, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants