brush: Convert SmudgeBucket from array to struct#197
Draft
Conversation
This will make the code slightly more readable.
jtojnar
force-pushed
the
wip/jtojnar/smudge-bucket-struct
branch
from
223bf61 to
cff0fe4
Compare
jtojnar
commented
Aug 4, 2024
| return &STATE(self, SMUDGE_RA); | ||
| float *smudge_state = &STATE(self, SMUDGE_RA); | ||
| // Not sure this can be done in general. | ||
| // static_assert (sizeof (SmudgeBucket) == sizeof(smudge_state) * SMUDGE_BUCKET_SIZE, "SmudgeBucket includes padding"); |
Member
Author
There was a problem hiding this comment.
Not sure this can be done in general. We might need something like __attribute__((packed)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the code slightly more readable.
Noticed during #186